add flake8 for python
This commit is contained in:
@@ -2,9 +2,16 @@ from django.contrib import admin
|
||||
|
||||
from .models import Signup
|
||||
|
||||
|
||||
@admin.register(Signup)
|
||||
class SignupAdmin(admin.ModelAdmin):
|
||||
_all_fields = ["email", "created_at", "anonymized_ip", "user_agent", "geoip"]
|
||||
_all_fields = [
|
||||
"email",
|
||||
"created_at",
|
||||
"anonymized_ip",
|
||||
"user_agent",
|
||||
"geoip"
|
||||
]
|
||||
|
||||
date_hierarchy = "created_at"
|
||||
list_display = ["email", "created_at", "user_agent"] + ["place_name"]
|
||||
|
||||
@@ -1,15 +1,16 @@
|
||||
from django.db import models
|
||||
|
||||
|
||||
class Signup(models.Model):
|
||||
email = models.EmailField()
|
||||
created_at = models.DateTimeField(auto_now_add = True)
|
||||
created_at = models.DateTimeField(auto_now_add=True)
|
||||
anonymized_ip = models.GenericIPAddressField()
|
||||
user_agent = models.CharField(max_length = 255)
|
||||
geoip = models.JSONField(null = True, blank = True)
|
||||
user_agent = models.CharField(max_length=255)
|
||||
geoip = models.JSONField(null=True, blank=True)
|
||||
|
||||
class Meta:
|
||||
constraints = [
|
||||
models.UniqueConstraint(name = "unique_email", fields = ["email"]),
|
||||
models.UniqueConstraint(name="unique_email", fields=["email"]),
|
||||
]
|
||||
|
||||
def __str__(self):
|
||||
|
||||
@@ -3,6 +3,7 @@ from django.urls import reverse
|
||||
|
||||
from .models import Signup
|
||||
|
||||
|
||||
class SignupViewTest(TestCase):
|
||||
def setUp(self):
|
||||
self.client = Client()
|
||||
@@ -14,9 +15,9 @@ class SignupViewTest(TestCase):
|
||||
|
||||
def test_ok_signup(self):
|
||||
resp = self.client.post(reverse("index"), {"email": "foo@example.com"},
|
||||
follow = True,
|
||||
HTTP_USER_AGENT = "foo-agent",
|
||||
REMOTE_ADDR = "127.0.0.2")
|
||||
follow=True,
|
||||
HTTP_USER_AGENT="foo-agent",
|
||||
REMOTE_ADDR="127.0.0.2")
|
||||
self.assertEqual(resp.redirect_chain, [('/?success=subscribed', 302)])
|
||||
self.assertContains(resp, "You are now subscribed!")
|
||||
obj = Signup.objects.get()
|
||||
|
||||
@@ -31,10 +31,10 @@ def index(request):
|
||||
geoip = None
|
||||
|
||||
s = Signup(
|
||||
email = request.POST.get("email"),
|
||||
anonymized_ip = anonymous_ip,
|
||||
user_agent = request.META["HTTP_USER_AGENT"],
|
||||
geoip = geoip,
|
||||
email=request.POST.get("email"),
|
||||
anonymized_ip=anonymous_ip,
|
||||
user_agent=request.META["HTTP_USER_AGENT"],
|
||||
geoip=geoip,
|
||||
)
|
||||
|
||||
try:
|
||||
@@ -42,7 +42,7 @@ def index(request):
|
||||
except ValidationError as e:
|
||||
print(e)
|
||||
return render(request, "signup/index.html",
|
||||
{"error_message": e.message})
|
||||
{"error_message": e.message})
|
||||
|
||||
logging.info("registering email={}".format(request.POST.get("email")))
|
||||
try:
|
||||
@@ -52,7 +52,7 @@ def index(request):
|
||||
return redirect(reverse("index") + "?success=already_subscribed")
|
||||
except DatabaseError:
|
||||
logger.exception("database error when registering an email")
|
||||
err = "Sorry, database error. Please come back later."
|
||||
err = "Sorry, database error. Please come back later."
|
||||
return render(request, "signup/index.html",
|
||||
{"error_message": err})
|
||||
return redirect(reverse("index") + "?success=subscribed")
|
||||
|
||||
Reference in New Issue
Block a user