motiejus/hermetic_cc_toolchain
1
Fork 0
Code Releases Activity

remove DEFAULT_COPTS

Browse Source 
Optimizations should be turned by the user with `-c opt`. We want UBSAN
enabled for non-release builds.
This commit is contained in:
Motiejus Jakštys 2021-12-13 03:20:49 +02:00
parent 66dbf420f7
commit 985e26b474
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
toolchain/defs.bzl
View File

@ -18,10 +18,6 @@ DEFAULT_INCLUDE_DIRECTORIES = [
"libcxxabi/include", "libcxxabi/include",
] ]
# -Os, -O2 or -O3 must be set, because some dependencies use C's undefined
# behavior. See https://github.com/ziglang/zig/issues/4830
DEFAULT_COPTS = ["-O3"]
_fcntl_map = """ _fcntl_map = """
GLIBC_2.2.5 { GLIBC_2.2.5 {
fcntl; fcntl;
@ -69,7 +65,7 @@ def _target_darwin(gocpu, zigcpu):
"libc/include/any-macos-any", "libc/include/any-macos-any",
], ],
linkopts = [], linkopts = [],
copts = DEFAULT_COPTS, copts = [],
bazel_target_cpu = "darwin", bazel_target_cpu = "darwin",
constraint_values = [ constraint_values = [
"@platforms//os:macos", "@platforms//os:macos",
@ -111,7 +107,7 @@ def _target_linux_gnu(gocpu, zigcpu, glibc_version = ""):
compiler_extra_includes = ["glibc-hacks/glibchack-fcntl.h"] if fcntl_hack else [], compiler_extra_includes = ["glibc-hacks/glibchack-fcntl.h"] if fcntl_hack else [],
linker_version_scripts = ["glibc-hacks/fcntl.map"] if fcntl_hack else [], linker_version_scripts = ["glibc-hacks/fcntl.map"] if fcntl_hack else [],
linkopts = ["-lc++", "-lc++abi"], linkopts = ["-lc++", "-lc++abi"],
copts = DEFAULT_COPTS, copts = [],
bazel_target_cpu = "k8", bazel_target_cpu = "k8",
constraint_values = [ constraint_values = [
"@platforms//os:linux", "@platforms//os:linux",
@ -131,7 +127,7 @@ def _target_linux_musl(gocpu, zigcpu):
"libc/include/{}-linux-any".format(zigcpu), "libc/include/{}-linux-any".format(zigcpu),
] + ["libc/include/x86-linux-any"] if zigcpu == "x86_64" else [], ] + ["libc/include/x86-linux-any"] if zigcpu == "x86_64" else [],
linkopts = ["-s", "-w"], linkopts = ["-s", "-w"],
copts = DEFAULT_COPTS + ["-D_LIBCPP_HAS_MUSL_LIBC", "-D_LIBCPP_HAS_THREAD_API_PTHREAD"], copts = ["-D_LIBCPP_HAS_MUSL_LIBC", "-D_LIBCPP_HAS_THREAD_API_PTHREAD"],
bazel_target_cpu = "k8", bazel_target_cpu = "k8",
constraint_values = [ constraint_values = [
"@platforms//os:linux", "@platforms//os:linux",