motiejus/hermetic_cc_toolchain
1
Fork 0
Code Releases Activity

CGo-specific: reduce unneeded compilation

Browse Source 
This adds an ugly workaround for
https://go-review.googlesource.com/c/go/+/436884 ; fingers crossed.

Impact: ~20-25s reduced first build time for a particular
architecture+glibc.
This commit is contained in:
Motiejus Jakštys 2022-09-30 14:24:56 +03:00
parent ae57dac00d
commit 9e8d89b40d
1 changed files with 23 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
toolchain/defs.bzl
View File

@ -131,7 +131,8 @@ else
fi fi
export ZIG_LOCAL_CACHE_DIR="{cache_prefix}/bazel-zig-cc" export ZIG_LOCAL_CACHE_DIR="{cache_prefix}/bazel-zig-cc"
export ZIG_GLOBAL_CACHE_DIR="{cache_prefix}/bazel-zig-cc" export ZIG_GLOBAL_CACHE_DIR="{cache_prefix}/bazel-zig-cc"
exec "{zig}" "{zig_tool}" "$@" {common}
exec "{zig}" "{zig_tool}" "$@" $maybe_o2
""" """
_ZIG_TOOL_WRAPPER_CACHE_GUESS = """#!/bin/sh _ZIG_TOOL_WRAPPER_CACHE_GUESS = """#!/bin/sh
@ -154,7 +155,22 @@ else
fi fi
export ZIG_LOCAL_CACHE_DIR="$_cache_prefix/bazel-zig-cc" export ZIG_LOCAL_CACHE_DIR="$_cache_prefix/bazel-zig-cc"
export ZIG_GLOBAL_CACHE_DIR=$ZIG_LOCAL_CACHE_DIR export ZIG_GLOBAL_CACHE_DIR=$ZIG_LOCAL_CACHE_DIR
exec "{zig}" "{zig_tool}" "$@" {common}
exec "{zig}" "{zig_tool}" "$@" $maybe_o2
"""
# The abomination below adds "-O2" to Go's link-prober command. Saves around
# 25s for the first compilation for a particular architecture. Can be deleted
# if/after https://go-review.googlesource.com/c/go/+/436884 is merged.
# Shell hackery taken from
# https://web.archive.org/web/20100129154217/http://www.seanius.net/blog/2009/03/saving-and-restoring-positional-params
_ZIG_TOOL_COMMON_UNIX = """
quote(){ echo "$1" | sed -e "s,','\\\\'',g"; }
for arg in "$@"; do saved="${saved:+$saved }'$(quote "$arg")'"; done
maybe_o2=
while [ "$#" -gt 6 ]; do shift; done
[ "$*" = "-Wl,--no-gc-sections -x c - -o /dev/null" ] && maybe_o2="-O2"
eval set -- "$saved"
""" """
def _zig_tool_wrapper(zig_tool, zig, is_windows, cache_prefix): def _zig_tool_wrapper(zig_tool, zig, is_windows, cache_prefix):
@ -169,7 +185,9 @@ def _zig_tool_wrapper(zig_tool, zig, is_windows, cache_prefix):
return _ZIG_TOOL_WRAPPER_WINDOWS_CACHE_KNOWN.format(**kwargs) return _ZIG_TOOL_WRAPPER_WINDOWS_CACHE_KNOWN.format(**kwargs)
else: else:
return _ZIG_TOOL_WRAPPER_WINDOWS_CACHE_GUESS.format(**kwargs) return _ZIG_TOOL_WRAPPER_WINDOWS_CACHE_GUESS.format(**kwargs)
elif cache_prefix: else:
kwargs['common'] = _ZIG_TOOL_COMMON_UNIX
if cache_prefix:
return _ZIG_TOOL_WRAPPER_CACHE_KNOWN.format(**kwargs) return _ZIG_TOOL_WRAPPER_CACHE_KNOWN.format(**kwargs)
else: else:
return _ZIG_TOOL_WRAPPER_CACHE_GUESS.format(**kwargs) return _ZIG_TOOL_WRAPPER_CACHE_GUESS.format(**kwargs)