From ae57dac00dc2b560a68a28161783deeb3b6c3c28 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Motiejus=20Jak=C5=A1tys?= <motiejus@uber.com>
Date: Thu, 29 Sep 2022 12:11:34 +0300
Subject: [PATCH] ci/lint: make it fail in CI

It would "fix" the files on CI and not fail. ci/lint should verify they
are OK first, and give guidance to fix them.

also, `shellcheck -x` is no longer necessary; we can use the plain one
now.
---
 ci/lint | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/ci/lint b/ci/lint
index 8d3c919..f19f89a 100755
--- a/ci/lint
+++ b/ci/lint
@@ -12,10 +12,19 @@ mapfile -t buildfiles < \
 
 >&2 echo "shellcheck"
 for f in "${scripts[@]}"; do >&2 echo "  $f"; done
-shellcheck -x "${scripts[@]}"
+shellcheck "${scripts[@]}"
 >&2 echo -e "OK\n"
 
->&2 echo "buildifier"
+>&2 echo "buildifier -mode diff"
 for f in "${buildfiles[@]}"; do >&2 echo "  $f"; done
-buildifier "${buildfiles[@]}"
+fail=0
+out=$(buildifier -mode diff -diff_command='diff -u' "${buildfiles[@]}") || fail=1
+if [[ "$fail" == 1 ]]; then
+    >&2 echo "ERROR: buildifier:"
+    echo "$out"
+    >&2 echo
+    >&2 echo "You may try running:"
+    >&2 echo "  buildifier ${buildfiles[*]}"
+    exit 1
+fi
 >&2 echo -e "OK\n"