motiejus
/
jgit
1
Fork 0
Code Releases Activity

CommitBuilder: Deprecate setEncoding(String) 

Deprecate the method in favor of setEncoding(Charset).

Update the only caller in the code base that was still using
the deprecated variant.

Change-Id: I6357f2d0c727007013c72e9d5b7c72a3f5f3f2b1
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
This commit is contained in:
David Pursehouse 2019-02-15 16:46:37 +09:00 committed by Matthias Sohn
parent e5c4057467
commit 0368906353
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/T0003_BasicTest.java
View File

@ -538,7 +538,7 @@ public void test024_createCommitNonAscii() throws IOException {
4294967295000L, 60));
commit.setCommitter(new PersonIdent("Joe Hacker", "joe2@example.com",
4294967295000L, 60));
commit.setEncoding("ISO-8859-1");
commit.setEncoding(ISO_8859_1);
commit.setMessage("\u00dcbergeeks");
ObjectId cid = insertCommit(commit);
assertEquals("2979b39d385014b33287054b87f77bcb3ecb5ebf", cid.name());

2
org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitBuilder.java
View File

@ -295,7 +295,9 @@ public void setMessage(String newMessage) {
* @param encodingName
* the encoding name. See
* {@link java.nio.charset.Charset#forName(String)}.
* @deprecated use {@link #setEncoding(Charset)} instead.
*/
@Deprecated
public void setEncoding(String encodingName) {
encoding = Charset.forName(encodingName);
}