motiejus
/
jgit
1
Fork 0
Code Releases Activity

Add MutableObjectId.copyFrom(AnyObjectId) 

This simplifies the PackIndex code, which is trying to quickly copy
an existing ObjectId into a MutableObjectId.  Rather than having
the PackIndex violate the ObjectId's internals, expose a copy from
function similar to the other ones for copying from raw byte arrays
or hex formatted strings.

Change-Id: I142635cbece54af2ab83c58477961ce925dc8255
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
This commit is contained in:
Shawn O. Pearce 2010-06-22 16:42:29 -07:00
parent 677b9b17e2
commit 066df3d1a1
2 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
org.eclipse.jgit/src/org/eclipse/jgit/lib/MutableObjectId.java
View File

@ -71,11 +71,7 @@ public MutableObjectId() {
* original entry, to copy id from
*/
MutableObjectId(MutableObjectId src) {
this.w1 = src.w1;
this.w2 = src.w2;
this.w3 = src.w3;
this.w4 = src.w4;
this.w5 = src.w5;
fromObjectId(src);
}
/** Make this id match {@link ObjectId#zeroId()}. */
@ -87,6 +83,20 @@ public void clear() {
w5 = 0;
}
/**
* Copy an ObjectId into this mutable buffer.
*
* @param src
* the source id to copy from.
*/
public void fromObjectId(AnyObjectId src) {
this.w1 = src.w1;
this.w2 = src.w2;
this.w3 = src.w3;
this.w4 = src.w4;
this.w5 = src.w5;
}
/**
* Convert an ObjectId from raw binary representation.
*

6
org.eclipse.jgit/src/org/eclipse/jgit/lib/PackIndex.java
View File

@ -281,11 +281,7 @@ public ObjectId toObjectId() {
public MutableEntry cloneEntry() {
final MutableEntry r = new MutableEntry();
ensureId();
r.idBuffer.w1 = idBuffer.w1;
r.idBuffer.w2 = idBuffer.w2;
r.idBuffer.w3 = idBuffer.w3;
r.idBuffer.w4 = idBuffer.w4;
r.idBuffer.w5 = idBuffer.w5;
r.idBuffer.fromObjectId(idBuffer);
r.offset = offset;
return r;
}