From 06b183f9b7f902d3e81bea9aa909a044f76d79fb Mon Sep 17 00:00:00 2001 From: Robin Rosenberg Date: Sun, 9 Oct 2011 14:47:19 +0200 Subject: [PATCH] Add a method to SystemReader to get the time zone Change-Id: Ifd31f408ed2c5b7869694b715fea3219e74963ef --- .../src/org/eclipse/jgit/junit/MockSystemReader.java | 6 +++++- .../src/org/eclipse/jgit/pgm/Log.java | 3 ++- .../src/org/eclipse/jgit/util/SystemReader.java | 11 ++++++++++- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/MockSystemReader.java b/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/MockSystemReader.java index b53dce216..3daaea90c 100644 --- a/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/MockSystemReader.java +++ b/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/MockSystemReader.java @@ -137,7 +137,11 @@ public long getCurrentTime() { @Override public int getTimezone(long when) { - return TimeZone.getTimeZone("GMT-03:30").getOffset(when) / (60 * 1000); + return getTimeZone().getOffset(when) / (60 * 1000); } + @Override + public TimeZone getTimeZone() { + return TimeZone.getTimeZone("GMT-03:30"); + } } diff --git a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Log.java b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Log.java index 4a92ea624..6cc009380 100644 --- a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Log.java +++ b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Log.java @@ -73,11 +73,12 @@ import org.eclipse.jgit.notes.NoteMap; import org.eclipse.jgit.revwalk.RevCommit; import org.eclipse.jgit.revwalk.RevTree; +import org.eclipse.jgit.util.SystemReader; import org.kohsuke.args4j.Option; @Command(common = true, usage = "usage_viewCommitHistory") class Log extends RevWalkTextBuiltin { - private final TimeZone myTZ = TimeZone.getDefault(); + private final TimeZone myTZ = SystemReader.getInstance().getTimeZone(); private final DateFormat fmt; diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/util/SystemReader.java b/org.eclipse.jgit/src/org/eclipse/jgit/util/SystemReader.java index ced1d90b8..0b72ade50 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/util/SystemReader.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/util/SystemReader.java @@ -118,7 +118,11 @@ public long getCurrentTime() { @Override public int getTimezone(long when) { - return TimeZone.getDefault().getOffset(when) / (60 * 1000); + return getTimeZone().getOffset(when) / (60 * 1000); + } + + public TimeZone getTimeZone() { + return TimeZone.getDefault(); } }; @@ -187,4 +191,9 @@ public static void setInstance(SystemReader newReader) { * @return the local time zone */ public abstract int getTimezone(long when); + + /** + * @return system time zone, possibly mocked for testing + */ + public abstract TimeZone getTimeZone(); }