motiejus
/
jgit
1
Fork 0
Code Releases Activity

Revert "[findBugs] Silence DM_STRING_CTOR on PacketLineIn" 

This reverts commit 1e510ec20e.

Instead work around the warning by defining our constant by
constructing it through a StringBuilder.

Change-Id: If139509e769d649609c62eff359ebaea5dd286b2
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
CC: Matthias Sohn <matthias.sohn@sap.com>
CC: Chris Aniszczyk <caniszczyk@gmail.com>
This commit is contained in:
Shawn O. Pearce 2010-11-08 15:34:47 -08:00
parent 2dc2dd8b1b
commit 08a9682e32
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml
View File

@ -38,12 +38,4 @@
<Class name="org.eclipse.jgit.util.TemporaryBuffer$BlockInputStream" />
<Bug pattern="UR_UNINIT_READ" />
</Match>
<!-- Silence invoke inefficient String constructor, we do not want to pool
here -->
<Match>
<Class name="org.eclipse.jgit.transport.PacketLineIn" />
<Method name="&lt;clinit&gt;" />
<Bug pattern="DM_STRING_CTOR" />
</Match>
</FindBugsFilter>

3
org.eclipse.jgit/src/org/eclipse/jgit/transport/PacketLineIn.java
View File

@ -57,7 +57,8 @@
import org.eclipse.jgit.util.RawParseUtils;
class PacketLineIn {
static final String END = new String("") /* must not string pool */;
/* must not string pool */
static final String END = new StringBuilder(0).toString();
static enum AckNackResult {
/** NAK */