From 1d073e30d7486ee0116931d045c45b6abf235299 Mon Sep 17 00:00:00 2001 From: Matthias Sohn Date: Thu, 2 Mar 2023 10:43:10 +0100 Subject: [PATCH] [errorprone] Suppress [Finally] warnings In these cases we use Throwable#addSuppressed to ensure the exception thrown in the catch block preceding the finally block throwing another exception isn't lost. Change-Id: I96e78a5c15238ab77ac90ca1901850ce19acfcd8 --- .../src/org/eclipse/jgit/transport/FetchProcess.java | 1 + .../src/org/eclipse/jgit/transport/WalkFetchConnection.java | 1 + 2 files changed, 2 insertions(+) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/FetchProcess.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/FetchProcess.java index e0eb12644..f02160e45 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/FetchProcess.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/FetchProcess.java @@ -90,6 +90,7 @@ class FetchProcess { .collect(Collectors.toList()); } + @SuppressWarnings("Finally") void execute(ProgressMonitor monitor, FetchResult result, String initialBranch) throws NotSupportedException, TransportException { diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/WalkFetchConnection.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/WalkFetchConnection.java index d67fe074e..ed8f450c5 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/WalkFetchConnection.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/WalkFetchConnection.java @@ -470,6 +470,7 @@ private boolean alreadyHave(AnyObjectId id) throws TransportException { } } + @SuppressWarnings("Finally") private boolean downloadPackedObject(final ProgressMonitor monitor, final AnyObjectId id) throws TransportException { // Search for the object in a remote pack whose index we have,