From 239043e59d78b6c8661eb9fcd51189887c081770 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Wed, 6 Dec 2017 23:27:09 +0900 Subject: [PATCH] LfsStore: Make inner class AppServer static FindBugs reports: This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static. Change-Id: I245e44678166176de0cfb275e22ddd159f88e0bd Signed-off-by: David Pursehouse --- .../src/org/eclipse/jgit/pgm/debug/LfsStore.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/debug/LfsStore.java b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/debug/LfsStore.java index 5839f3395..9dc47210d 100644 --- a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/debug/LfsStore.java +++ b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/debug/LfsStore.java @@ -82,7 +82,7 @@ class LfsStore extends TextBuiltin { /** * Tiny web application server for testing */ - class AppServer { + static class AppServer { private final Server server;