From 241ab2273557185c2b76cedca5a133055ab6e39a Mon Sep 17 00:00:00 2001
From: Chris Aniszczyk <caniszczyk@gmail.com>
Date: Thu, 14 Oct 2010 09:26:46 -0700
Subject: [PATCH] Add FindBugs and CPD to the build.

We need to use findbugs-maven-plugin:2.3.2-SNAPSHOT
since otherwise build fails with maven-3.0 [1], [2].
We should switch to the release version as soon
as this becomes available.

[1] http://www.sonatype.com/people/2010/10/maven-3-0-has-landed/
[2] http://jira.codehaus.org/browse/MFINDBUGS-122

Bug: 327799
Change-Id: I1c57f81cf6f0450e56411881488c4ee754e458e3
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
---
 org.eclipse.jgit.console/pom.xml     | 35 +++++++++++++++++++++++++++-
 org.eclipse.jgit.http.server/pom.xml | 33 ++++++++++++++++++++++++++
 org.eclipse.jgit.ui/pom.xml          | 33 ++++++++++++++++++++++++++
 org.eclipse.jgit/pom.xml             | 33 ++++++++++++++++++++++++++
 pom.xml                              | 25 ++++++++++++++++++++
 5 files changed, 158 insertions(+), 1 deletion(-)

diff --git a/org.eclipse.jgit.console/pom.xml b/org.eclipse.jgit.console/pom.xml
index 6ca1cdc98..dde64c259 100644
--- a/org.eclipse.jgit.console/pom.xml
+++ b/org.eclipse.jgit.console/pom.xml
@@ -107,6 +107,39 @@
           <encoding>UTF-8</encoding>
         </configuration>
       </plugin>
-    </plugins>
+         <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>findbugs-maven-plugin</artifactId>
+            <configuration>
+               <findbugsXmlOutput>true</findbugsXmlOutput>
+               <failOnError>false</failOnError>
+            </configuration>
+            <executions>
+               <execution>
+                  <goals>
+                     <goal>check</goal>
+                  </goals>
+               </execution>
+            </executions>
+         </plugin>
+         <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-pmd-plugin</artifactId>
+            <configuration>
+               <sourceEncoding>utf-8</sourceEncoding>
+               <minimumTokens>100</minimumTokens>
+               <targetJdk>1.5</targetJdk>
+               <format>xml</format>
+               <failOnViolation>false</failOnViolation>
+            </configuration>
+            <executions>
+               <execution>
+                  <goals>
+                     <goal>cpd-check</goal>
+                  </goals>
+               </execution>
+            </executions>
+         </plugin>
+      </plugins>
   </build>
 </project>
diff --git a/org.eclipse.jgit.http.server/pom.xml b/org.eclipse.jgit.http.server/pom.xml
index 4b91d9afb..05412cb4d 100644
--- a/org.eclipse.jgit.http.server/pom.xml
+++ b/org.eclipse.jgit.http.server/pom.xml
@@ -104,6 +104,39 @@
           </archive>
         </configuration>
       </plugin>
+         <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>findbugs-maven-plugin</artifactId>
+            <configuration>
+               <findbugsXmlOutput>true</findbugsXmlOutput>
+               <failOnError>false</failOnError>
+            </configuration>
+            <executions>
+               <execution>
+                  <goals>
+                     <goal>check</goal>
+                  </goals>
+               </execution>
+            </executions>
+         </plugin>
+         <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-pmd-plugin</artifactId>
+            <configuration>
+               <sourceEncoding>utf-8</sourceEncoding>
+               <minimumTokens>100</minimumTokens>
+               <targetJdk>1.5</targetJdk>
+               <format>xml</format>
+               <failOnViolation>false</failOnViolation>
+            </configuration>
+            <executions>
+               <execution>
+                  <goals>
+                     <goal>cpd-check</goal>
+                  </goals>
+               </execution>
+            </executions>
+         </plugin>
     </plugins>
   </build>
 </project>
diff --git a/org.eclipse.jgit.ui/pom.xml b/org.eclipse.jgit.ui/pom.xml
index 2e7edb855..8d3b0f4d1 100644
--- a/org.eclipse.jgit.ui/pom.xml
+++ b/org.eclipse.jgit.ui/pom.xml
@@ -98,6 +98,39 @@
           </archive>
         </configuration>
       </plugin>
+         <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>findbugs-maven-plugin</artifactId>
+            <configuration>
+               <findbugsXmlOutput>true</findbugsXmlOutput>
+               <failOnError>false</failOnError>
+            </configuration>
+            <executions>
+               <execution>
+                  <goals>
+                     <goal>check</goal>
+                  </goals>
+               </execution>
+            </executions>
+         </plugin>
+         <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-pmd-plugin</artifactId>
+            <configuration>
+               <sourceEncoding>utf-8</sourceEncoding>
+               <minimumTokens>100</minimumTokens>
+               <targetJdk>1.5</targetJdk>
+               <format>xml</format>
+               <failOnViolation>false</failOnViolation>
+            </configuration>
+            <executions>
+               <execution>
+                  <goals>
+                     <goal>cpd-check</goal>
+                  </goals>
+               </execution>
+            </executions>
+         </plugin>
     </plugins>
   </build>
 </project>
diff --git a/org.eclipse.jgit/pom.xml b/org.eclipse.jgit/pom.xml
index 42cd70b32..284be8d51 100644
--- a/org.eclipse.jgit/pom.xml
+++ b/org.eclipse.jgit/pom.xml
@@ -141,6 +141,39 @@
           </archive>
         </configuration>
       </plugin>
+         <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>findbugs-maven-plugin</artifactId>
+            <configuration>
+               <findbugsXmlOutput>true</findbugsXmlOutput>
+               <failOnError>false</failOnError>
+            </configuration>
+            <executions>
+               <execution>
+                  <goals>
+                     <goal>check</goal>
+                  </goals>
+               </execution>
+            </executions>
+         </plugin>
+         <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-pmd-plugin</artifactId>
+            <configuration>
+               <sourceEncoding>utf-8</sourceEncoding>
+               <minimumTokens>100</minimumTokens>
+               <targetJdk>1.5</targetJdk>
+               <format>xml</format>
+               <failOnViolation>false</failOnViolation>
+            </configuration>
+            <executions>
+               <execution>
+                  <goals>
+                     <goal>cpd-check</goal>
+                  </goals>
+               </execution>
+            </executions>
+         </plugin>
     </plugins>
   </build>
 </project>
diff --git a/pom.xml b/pom.xml
index 00865fa80..a6c76e5b3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -137,6 +137,16 @@
     <jetty-version>7.0.1.v20091125</jetty-version>
   </properties>
 
+  <pluginRepositories>
+    <pluginRepository>
+      <!-- need maven-findbugs-2.3.2-SNAPSHOT, see
+           http://jira.codehaus.org/browse/MFINDBUGS-122
+           remove this when this version is released -->
+      <id>codehaus.snapshots</id>
+      <url>http://snapshots.repository.codehaus.org/</url>
+    </pluginRepository>
+  </pluginRepositories>
+
   <build>
     <pluginManagement>
       <plugins>
@@ -202,6 +212,21 @@
           <artifactId>build-helper-maven-plugin</artifactId>
           <version>1.5</version>
         </plugin>
+
+        <plugin>
+          <!-- need maven-findbugs-2.3.2-SNAPSHOT, see
+               http://jira.codehaus.org/browse/MFINDBUGS-122
+               switch to released version when available -->
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>findbugs-maven-plugin</artifactId>
+          <version>2.3.2-SNAPSHOT</version>
+        </plugin>
+
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-pmd-plugin</artifactId>
+          <version>2.5</version>
+        </plugin>
       </plugins>
     </pluginManagement>