motiejus
/
jgit
1
Fork 0
Code Releases Activity

s/StringBuffer/StringBuilder as appropriate where no concurrency is needed

This commit is contained in:
Karthik K 2010-03-11 23:31:38 -08:00
parent 48af6a5f53
commit 2c14e78a22
13 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
org.eclipse.jgit/src/org/eclipse/jgit/lib/Config.java
View File

@ -118,7 +118,7 @@ public Config(Config defaultConfig) {
private static String escapeValue(final String x) {
boolean inquote = false;
int lineStart = 0;
final StringBuffer r = new StringBuffer(x.length());
final StringBuilder r = new StringBuilder(x.length());
for (int k = 0; k < x.length(); k++) {
final char c = x.charAt(k);
switch (c) {
@ -897,7 +897,7 @@ private static String readSectionName(final StringReader in)
private static String readKeyName(final StringReader in)
throws ConfigInvalidException {
final StringBuffer name = new StringBuffer();
final StringBuilder name = new StringBuilder();
for (;;) {
int c = in.read();
if (c < 0)
@ -944,7 +944,7 @@ private static String readKeyName(final StringReader in)
private static String readValue(final StringReader in, boolean quote,
final int eol) throws ConfigInvalidException {
final StringBuffer value = new StringBuffer();
final StringBuilder value = new StringBuilder();
boolean space = false;
for (;;) {
int c = in.read();

2
org.eclipse.jgit/src/org/eclipse/jgit/lib/FileTreeEntry.java
View File

@ -106,7 +106,7 @@ public void accept(final TreeVisitor tv, final int flags)
}
public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append(ObjectId.toString(getId()));
r.append(' ');
r.append(isExecutable() ? 'X' : 'F');

2
org.eclipse.jgit/src/org/eclipse/jgit/lib/GitlinkTreeEntry.java
View File

@ -83,7 +83,7 @@ public void accept(final TreeVisitor tv, final int flags)
@Override
public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append(ObjectId.toString(getId()));
r.append(" G ");
r.append(getFullName());

8
org.eclipse.jgit/src/org/eclipse/jgit/lib/PersonIdent.java
View File

@ -251,7 +251,7 @@ public Date getWhen() {
* @return this person's declared time zone; null if time zone is unknown.
*/
public TimeZone getTimeZone() {
StringBuffer tzId = new StringBuffer(8);
StringBuilder tzId = new StringBuilder(8);
tzId.append("GMT");
appendTimezone(tzId);
return TimeZone.getTimeZone(tzId.toString());
@ -285,7 +285,7 @@ && getEmailAddress().equals(p.getEmailAddress())
* @return a string in the git author format
*/
public String toExternalString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append(getName());
r.append(" <");
r.append(getEmailAddress());
@ -296,7 +296,7 @@ public String toExternalString() {
return r.toString();
}
private void appendTimezone(final StringBuffer r) {
private void appendTimezone(final StringBuilder r) {
int offset = tzOffset;
final char sign;
final int offsetHours;
@ -324,7 +324,7 @@ private void appendTimezone(final StringBuffer r) {
}
public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
final SimpleDateFormat dtfmt;
dtfmt = new SimpleDateFormat("EEE MMM d HH:mm:ss yyyy Z", Locale.US);
dtfmt.setTimeZone(getTimeZone());

2
org.eclipse.jgit/src/org/eclipse/jgit/lib/SymlinkTreeEntry.java
View File

@ -81,7 +81,7 @@ public void accept(final TreeVisitor tv, final int flags)
}
public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append(ObjectId.toString(getId()));
r.append(" S ");
r.append(getFullName());

2
org.eclipse.jgit/src/org/eclipse/jgit/lib/Tag.java
View File

@ -163,7 +163,7 @@ private void decode() {
throw new CorruptObjectException(tagId, "no tagger/bad header");
// Message should start with an empty line, but
StringBuffer tempMessage = new StringBuffer();
StringBuilder tempMessage = new StringBuilder();
char[] readBuf = new char[2048];
int readLen;
while ((readLen = br.read(readBuf)) > 0) {

2
org.eclipse.jgit/src/org/eclipse/jgit/lib/Tree.java
View File

@ -598,7 +598,7 @@ else if (FileMode.GITLINK.equals(mode))
}
public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append(ObjectId.toString(getId()));
r.append(" T ");
r.append(getFullName());

4
org.eclipse.jgit/src/org/eclipse/jgit/lib/TreeEntry.java
View File

@ -210,7 +210,7 @@ public void setId(final ObjectId n) {
* @return repository relative name of this entry
*/
public String getFullName() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
appendFullName(r);
return r.toString();
}
@ -285,7 +285,7 @@ public void accept(final TreeVisitor tv) throws IOException {
*/
public abstract FileMode getMode();
private void appendFullName(final StringBuffer r) {
private void appendFullName(final StringBuilder r) {
final TreeEntry p = getParent();
final String n = getName();
if (p != null) {

2
org.eclipse.jgit/src/org/eclipse/jgit/revwalk/filter/AndRevFilter.java
View File

@ -170,7 +170,7 @@ public RevFilter clone() {
@Override
public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append("(");
for (int i = 0; i < subfilters.length; i++) {
if (i > 0)

2
org.eclipse.jgit/src/org/eclipse/jgit/revwalk/filter/OrRevFilter.java
View File

@ -168,7 +168,7 @@ public RevFilter clone() {
@Override
public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append("(");
for (int i = 0; i < subfilters.length; i++) {
if (i > 0)

2
org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/AndTreeFilter.java
View File

@ -182,7 +182,7 @@ public TreeFilter clone() {
@Override
public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append("(");
for (int i = 0; i < subfilters.length; i++) {
if (i > 0)

2
org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/OrTreeFilter.java
View File

@ -180,7 +180,7 @@ public TreeFilter clone() {
@Override
public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append("(");
for (int i = 0; i < subfilters.length; i++) {
if (i > 0)

2
org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/PathFilterGroup.java
View File

@ -192,7 +192,7 @@ public TreeFilter clone() {
}
public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append("FAST(");
for (int i = 0; i < paths.length; i++) {
if (i > 0)