motiejus
/
jgit
1
Fork 0
Code Releases Activity

[errorprone] TagCommand: Remove unused parameter of private method 

See https://errorprone.info/bugpattern/UnusedVariable

Change-Id: I7e8aae3494ce60dbeb474f6bead0817c36276e69
This commit is contained in:
Matthias Sohn 2023-09-20 22:18:01 +02:00
parent 28d4b34902
commit 2d16df1a07
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
org.eclipse.jgit/src/org/eclipse/jgit/api/TagCommand.java
View File

@ -33,7 +33,6 @@
import org.eclipse.jgit.lib.RefUpdate;
import org.eclipse.jgit.lib.RefUpdate.Result;
import org.eclipse.jgit.lib.Repository;
import org.eclipse.jgit.lib.RepositoryState;
import org.eclipse.jgit.lib.TagBuilder;
import org.eclipse.jgit.revwalk.RevObject;
import org.eclipse.jgit.revwalk.RevWalk;
@ -108,9 +107,7 @@ protected TagCommand(Repository repo) {
public Ref call() throws GitAPIException, ConcurrentRefUpdateException,
InvalidTagNameException, NoHeadException {
checkCallable();
RepositoryState state = repo.getRepositoryState();
processOptions(state);
processOptions();
try (RevWalk revWalk = new RevWalk(repo)) {
// if no id is set, we should attempt to use HEAD
@ -197,9 +194,6 @@ private Ref updateTagRef(ObjectId tagId, RevWalk revWalk,
* Sets default values for not explicitly specified options. Then validates
* that all required data has been provided.
*
* @param state
* the state of the repository we are working on
*
* @throws InvalidTagNameException
* if the tag name is null or invalid
* @throws ServiceUnavailableException
@ -208,7 +202,7 @@ private Ref updateTagRef(ObjectId tagId, RevWalk revWalk,
* if the tag should be signed but {@code gpg.format} is not
* {@link GpgFormat#OPENPGP}
*/
private void processOptions(RepositoryState state)
private void processOptions()
throws InvalidTagNameException, ServiceUnavailableException,
UnsupportedSigningFormatException {
if (name == null