motiejus
/
jgit
1
Fork 0
Code Releases Activity

BasePackFetchConnection: Prefer boolean operators over logical operators in comparisons 

Using the | and & operators in boolean conditions results in a warning
from Error Prone:

  [ShortCircuitBoolean]
  Prefer the short-circuiting boolean operators && and || to & and |.
  see https://errorprone.info/bugpattern/ShortCircuitBoolean

Change-Id: I6cccca3fdd28bf93b302a9b8a66e68ac912cb60d
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
This commit is contained in:
David Pursehouse 2019-06-12 13:12:52 +09:00 committed by Matthias Sohn
parent 858736df37
commit 2eeabde94a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackFetchConnection.java
View File

@ -670,7 +670,7 @@ private void negotiate(ProgressMonitor monitor) throws IOException,
}
}
if (noDone & receivedReady) {
if (noDone && receivedReady) {
break SEND_HAVES;
}
if (statelessRPC) {