motiejus
/
jgit
1
Fork 0
Code Releases Activity

GC: Close File.lines stream 

From File#lines javadoc: The returned stream from File Lines
encapsulates a Reader. If timely disposal of file system resources is
required, the try-with-resources construct should be used to ensure
that the stream's close method is
invoked after the stream operations are completed.

Wrap File.lines with try-with-resources.

Change-Id: I82c6faa3ef1083f6c7e964f96e9540b4db18eee8
Signed-off-by: Xing Huang <xingkhuang@google.com>
(cherry picked from commit 172a207945)
This commit is contained in:
Xing Huang 2023-03-21 17:27:49 -05:00 committed by Matthias Sohn
parent d9f75e8bb2
commit 3212c8fa38
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/GC.java
View File

@ -1683,8 +1683,9 @@ private void failedToLock() {
private void gcAlreadyRunning() {
close();
try {
Optional<String> s = Files.lines(pidFile).findFirst();
Optional<String> s;
try (Stream<String> lines = Files.lines(pidFile)) {
s = lines.findFirst();
String machine = null;
String pid = null;
if (s.isPresent()) {