From 396508e283f9e5810569471b933cf76e7b3e3a58 Mon Sep 17 00:00:00 2001 From: Matthias Sohn Date: Sun, 20 Nov 2022 21:33:17 +0100 Subject: [PATCH] SshTestGitServer: : ensure UploadPack is closed to fix resource leak Change-Id: Ib766f1d56b3ca7940c593ebfe0ac68fc5028a11c --- .../eclipse/jgit/junit/ssh/SshTestGitServer.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/org.eclipse.jgit.junit.ssh/src/org/eclipse/jgit/junit/ssh/SshTestGitServer.java b/org.eclipse.jgit.junit.ssh/src/org/eclipse/jgit/junit/ssh/SshTestGitServer.java index 4fe98f868..5d043ffc3 100644 --- a/org.eclipse.jgit.junit.ssh/src/org/eclipse/jgit/junit/ssh/SshTestGitServer.java +++ b/org.eclipse.jgit.junit.ssh/src/org/eclipse/jgit/junit/ssh/SshTestGitServer.java @@ -480,13 +480,13 @@ protected GitUploadPackCommand(String command, @Override public void run() { - UploadPack uploadPack = new UploadPack(repository); - String gitProtocol = getEnvironment().getEnv().get("GIT_PROTOCOL"); - if (gitProtocol != null) { - uploadPack - .setExtraParameters(Collections.singleton(gitProtocol)); - } - try { + try (UploadPack uploadPack = new UploadPack(repository)) { + String gitProtocol = getEnvironment().getEnv() + .get("GIT_PROTOCOL"); + if (gitProtocol != null) { + uploadPack.setExtraParameters( + Collections.singleton(gitProtocol)); + } uploadPack.upload(getInputStream(), getOutputStream(), getErrorStream()); onExit(0);