From 330c3cae728d113e5d2fd62124c26edfee45c7e2 Mon Sep 17 00:00:00 2001 From: Dave Borowitz Date: Wed, 20 Jun 2012 14:53:59 -0700 Subject: [PATCH] Serve 403 from RepositoryFilter on ServiceMayNotContinueException This has no effect on Git clients, but for browsers, 403 Forbidden may be more appropriate. 500 Internal Server Error implies that there is a problem with the server, whereas ServiceMayNotContinueException is specifically intended to cover cases where the server is functioning correctly but has determined that the request may not proceed. Change-Id: I825abd2a029d372060103655eabf488a0547c1e8 --- .../src/org/eclipse/jgit/http/server/RepositoryFilter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/RepositoryFilter.java b/org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/RepositoryFilter.java index 5b336b2f9..58404020c 100644 --- a/org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/RepositoryFilter.java +++ b/org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/RepositoryFilter.java @@ -143,7 +143,7 @@ public void doFilter(final ServletRequest request, res.sendError(SC_UNAUTHORIZED); return; } catch (ServiceMayNotContinueException e) { - sendError(req, res, SC_INTERNAL_SERVER_ERROR, e.getMessage()); + sendError(req, res, SC_FORBIDDEN, e.getMessage()); return; } try {