motiejus
/
jgit
1
Fork 0
Code Releases Activity

Fix BadComparable error flagged by error prone 

Running recent error prone version complaining on that code:

LfsPointer.java:171: error: [BadComparable] Possible sign flip from
narrowing conversion
		return (int) (getSize() - o.getSize());
		       ^
    (see https://errorprone.info/bugpattern/BadComparable)
  Did you mean 'return Long.compare(getSize(), o.getSize());'?

Bug: 562756
Change-Id: I0522f1025319a9290c448a064fbafdb4b16d1d59
Signed-off-by: David Ostrovsky <david@ostrovsky.org>
This commit is contained in:
David Ostrovsky 2020-05-22 07:49:49 +02:00 committed by Matthias Sohn
parent 55371c5f06
commit 3e2ec7e5e8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/LfsPointer.java
View File

@ -168,7 +168,7 @@ public int compareTo(LfsPointer o) {
return x;
}
return (int) (getSize() - o.getSize());
return Long.compare(getSize(), o.getSize());
}
}