motiejus
/
jgit
1
Fork 0
Code Releases Activity

Silence API warnings introduced by a85e817d 

a85e817d is a slightly breaking API change to classes that were
technically public and technically released in 4.0. However, it is
highly unlikely that people were actually depending on public behavior,
since there were no public methods to create PushCertificates with
anything other than null field values, or a PushCertificateParser that
did anything other than infinite loop or throw exceptions when reading.

Change-Id: I1d0ba9ea0a347e8ff5a0f4af169d9bb18c5838d2
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
This commit is contained in:
Matthias Sohn 2015-06-17 23:08:45 +02:00
parent 8b20f2c890
commit 4831470581
2 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
org.eclipse.jgit/.settings/.api_filters Normal file
View File

@ -0,0 +1,24 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<component id="org.eclipse.jgit" version="2">
<resource path="src/org/eclipse/jgit/transport/PushCertificate.java" type="org.eclipse.jgit.transport.PushCertificate">
<filter comment="PushCertificate wasn't really usable in 4.0" id="338722907">
<message_arguments>
<message_argument value="org.eclipse.jgit.transport.PushCertificate"/>
<message_argument value="PushCertificate()"/>
</message_arguments>
</filter>
<filter comment="PushCertificate wasn't really usable in 4.0" id="338792546">
<message_arguments>
<message_argument value="org.eclipse.jgit.transport.PushCertificate"/>
<message_argument value="getCommandList()"/>
</message_arguments>
</filter>
</resource>
<resource path="src/org/eclipse/jgit/transport/PushCertificateParser.java" type="org.eclipse.jgit.transport.PushCertificateParser">
<filter comment="PushCertificates haven't been really usable in 4.0" id="338849923">
<message_arguments>
<message_argument value="org.eclipse.jgit.transport.PushCertificateParser"/>
</message_arguments>
</filter>
</resource>
</component>

7
org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificate.java
View File

@ -167,7 +167,7 @@ public String getPushee() {
/**
* @return the raw nonce value that was presented by the pusher.
* @since 4.0
* @since 4.1
*/
public String getNonce() {
return nonce;
@ -200,7 +200,10 @@ public String getSignature() {
return signature;
}
/** @return text payload of the certificate for the signature verifier. */
/**
* @return text payload of the certificate for the signature verifier.
* @since 4.1
*/
public String toText() {
return new StringBuilder()
.append(VERSION).append(' ').append(version).append('\n')