From 4c33f70d5a591f4572b32186b39de4344d8bfe65 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Sun, 26 May 2019 17:47:08 +0900 Subject: [PATCH] Enable error-prone checks by default Based on recent work by Dave Borowitz on the Gerrit project [1, 2]. The warnings/error configuration is unchanged, but now the checks are enabled by default during the build rather than having to be manually invoked. [1] https://gerrit-review.googlesource.com/c/gerrit/+/225653 [2] https://gerrit-review.googlesource.com/c/gerrit/+/225714 Change-Id: I7f4849896af72de38880b13d64519cc93bb3d2a3 Signed-off-by: David Pursehouse --- .bazelrc | 1 + tools/BUILD | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.bazelrc b/.bazelrc index 2a990c712..3a61f8cb7 100644 --- a/.bazelrc +++ b/.bazelrc @@ -2,6 +2,7 @@ build --repository_cache=~/.gerritcodereview/bazel-cache/repository build --experimental_strict_action_env build --action_env=PATH build --disk_cache=~/.gerritcodereview/bazel-cache/cas +build --java_toolchain //tools:error_prone_warnings_toolchain test --build_tests_only test --test_output=errors diff --git a/tools/BUILD b/tools/BUILD index 9025e0a6d..b39ac4f90 100644 --- a/tools/BUILD +++ b/tools/BUILD @@ -14,8 +14,10 @@ default_java_toolchain( visibility = ["//visibility:public"], ) -# This EP warnings list borrowed from here: +# Error Prone errors enabled by default; see ../.bazelrc for how this is +# enabled. This warnings list is originally based on: # https://github.com/bazelbuild/BUILD_file_generator/blob/master/tools/bazel_defs/java.bzl +# However, feel free to add any additional errors. Thus far they have all been pretty useful. java_package_configuration( name = "error_prone", javacopts = [