From 4ddc64a2ddaccb1304f52b07470c7d04fce85bd7 Mon Sep 17 00:00:00 2001 From: Matthias Sohn Date: Sun, 20 Nov 2022 21:21:26 +0100 Subject: [PATCH] [pgm] Ensure UploadPack is closed to fix resource leak Change-Id: I40da4b331012dd1c6f4b497e46c973fd776b737f --- .../src/org/eclipse/jgit/pgm/UploadPack.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/UploadPack.java b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/UploadPack.java index 36103f2e6..ac51643b6 100644 --- a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/UploadPack.java +++ b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/UploadPack.java @@ -42,12 +42,13 @@ protected void run() { try { FileKey key = FileKey.lenient(srcGitdir, FS.DETECTED); db = key.open(true /* must exist */); - org.eclipse.jgit.transport.UploadPack up = new org.eclipse.jgit.transport.UploadPack( - db); - if (0 <= timeout) { - up.setTimeout(timeout); + try (org.eclipse.jgit.transport.UploadPack up = new org.eclipse.jgit.transport.UploadPack( + db)) { + if (0 <= timeout) { + up.setTimeout(timeout); + } + up.upload(ins, outs, errs); } - up.upload(ins, outs, errs); } catch (RepositoryNotFoundException notFound) { throw die(MessageFormat.format(CLIText.get().notAGitRepository, srcGitdir.getPath()), notFound);