motiejus
/
jgit
1
Fork 0
Code Releases Activity

Fix FS.runProcess() to close the InputStream 

When FS.runProcess was called and an InputStream was given the method
tried to pump the whole InputStream to the process. When the method
ended the InputStream was not giving any data anymore. Consequently
close the InputStream inside the method.

Change-Id: I0ed738a775e5c977b21447d195acee1ecf5e2cb9
This commit is contained in:
Christian Halstrick 2015-11-24 11:18:59 +01:00 committed by Matthias Sohn
parent fe98218e0d
commit 55fb18feaa
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
org.eclipse.jgit/src/org/eclipse/jgit/util/FS.java
View File

@ -949,9 +949,7 @@ public int runProcess(ProcessBuilder processBuilder,
* @param outRedirect
* An OutputStream on which to redirect the processes stdout. Can
* be <code>null</code>, in which case the processes standard
* output will be lost. If binary is set to <code>false</code>
* then it is expected that the process emits text data which
* should be processed line by line.
* output will be lost.
* @param errRedirect
* An OutputStream on which to redirect the processes stderr. Can
* be <code>null</code>, in which case the processes standard
@ -959,9 +957,9 @@ public int runProcess(ProcessBuilder processBuilder,
* @param inRedirect
* An InputStream from which to redirect the processes stdin. Can
* be <code>null</code>, in which case the process doesn't get
* any data over stdin. If binary is set to
* <code>false</code> then it is expected that the process
* expects text data which should be processed line by line.
* any data over stdin. It is assumed that the whole InputStream
* will be consumed by the process. The method will close the
* inputstream after all bytes are read.
* @return the return code of this process.
* @throws IOException
* if an I/O error occurs while executing this process.
@ -1011,6 +1009,9 @@ public int runProcess(ProcessBuilder processBuilder,
// A process doesn't clean its own resources even when destroyed
// Explicitly try and close all three streams, preserving the
// outer I/O exception if any.
if (inRedirect != null) {
inRedirect.close();
}
try {
process.getErrorStream().close();
} catch (IOException e) {