PackWriter: Do not delta compress already packed objects
This is a tiny optimization to how delta search works. Checking for isReuseAsIs() avoids doing delta compression search on non-delta objects already stored in packs within the repository. Such objects are not likely to be delta compressable, as they were already delta searched when their containing pack was generated and they were not delta compressed at that time. Doing delta compression now is unlikely to produce a different result, but would waste a lot of CPU. The isReuseAsIs() flag is checked before isDoNotDelta() because it is very common to reuse objects in the output pack. Most objects get reused, and only a handful have the isDoNotDelta() bit set. Moving the check earlier allows the loop to more quickly skip through objects that will never need to be considered. Change-Id: Ied757363f775058177fc1befb8ace20fe9759bac Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
This commit is contained in:
parent
bf1b970de1
commit
67b064fc9f
|
@ -792,9 +792,9 @@ public int compare(ObjectToPack a, ObjectToPack b) {
|
||||||
|
|
||||||
private int findObjectsNeedingDelta(ObjectToPack[] list, int cnt, int type) {
|
private int findObjectsNeedingDelta(ObjectToPack[] list, int cnt, int type) {
|
||||||
for (ObjectToPack otp : objectsLists[type]) {
|
for (ObjectToPack otp : objectsLists[type]) {
|
||||||
if (otp.isDoNotDelta()) // delta is disabled for this path
|
if (otp.isReuseAsIs()) // already reusing a representation
|
||||||
continue;
|
continue;
|
||||||
if (otp.isDeltaRepresentation()) // already reusing a delta
|
if (otp.isDoNotDelta()) // delta is disabled for this path
|
||||||
continue;
|
continue;
|
||||||
otp.setWeight(0);
|
otp.setWeight(0);
|
||||||
list[cnt++] = otp;
|
list[cnt++] = otp;
|
||||||
|
|
Loading…
Reference in New Issue