From 6e4b9bd274fc50476eecdea1a0babe4972d2a623 Mon Sep 17 00:00:00 2001 From: Andrey Loskutov Date: Sun, 19 Aug 2018 18:08:50 +0200 Subject: [PATCH] ReceivePackAdvertiseRefsHookTest.testSuccess() fails on Windows The TransportLocal object created in newTransportLocalWithStrictValidation() closes original repository and increments use of test internal "dst" repository, but never decrements use. Because of this, pack file is not closed and during tearDown on Windows system is unable to delete it. Bug: 538068 Change-Id: I96df8e91abfee78c91cf26c2466718e9145a69db Signed-off-by: Andrey Loskutov --- .../eclipse/jgit/transport/ReceivePackAdvertiseRefsHookTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/ReceivePackAdvertiseRefsHookTest.java b/org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/ReceivePackAdvertiseRefsHookTest.java index b77042220..9cc6cfd39 100644 --- a/org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/ReceivePackAdvertiseRefsHookTest.java +++ b/org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/ReceivePackAdvertiseRefsHookTest.java @@ -259,6 +259,7 @@ public void testSuccess() throws Exception { try (TransportLocal t = newTransportLocalWithStrictValidation()) { t.setPushThin(true); r = t.push(PM, Collections.singleton(u)); + dst.close(); } assertNotNull("have result", r);