motiejus
/
jgit
1
Fork 0
Code Releases Activity

Make inner classes static in http code 

Static classes are preferrable to keep unwanted dependencies away, 
and they have one less member field.

Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
This commit is contained in:
Robin Rosenberg 2010-06-13 03:19:47 +02:00
parent 3bf96dd04b
commit 6f4cf8daec
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/AsIsServiceTest.java
View File

@ -112,7 +112,7 @@ public void testCreate_Enabled() throws ServiceNotEnabledException,
service.access(new R("bob", "1.2.3.4"), db);
}
private final class R extends HttpServletRequestWrapper {
private static final class R extends HttpServletRequestWrapper {
private final String user;
private final String host;

2
org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultReceivePackFactoryTest.java
View File

@ -174,7 +174,7 @@ public void testCreate_Enabled() throws ServiceNotEnabledException,
assertNotNull("have ReceivePack", rp);
}
private final class R extends HttpServletRequestWrapper {
private static final class R extends HttpServletRequestWrapper {
private final String user;
private final String host;

2
org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultUploadPackFactoryTest.java
View File

@ -136,7 +136,7 @@ public void testCreate_Enabled() throws ServiceNotEnabledException,
assertSame(db, up.getRepository());
}
private final class R extends HttpServletRequestWrapper {
private static final class R extends HttpServletRequestWrapper {
private final String user;
private final String host;