From 826fb260a3515c86eba9e65e54695c78a085425c Mon Sep 17 00:00:00 2001
From: "Shawn O. Pearce" <spearce@spearce.org>
Date: Fri, 24 Jun 2011 12:35:19 -0700
Subject: [PATCH] TemporaryBuffer: Fix reading from in-memory InputStream

I had the conditions wrong here, causing the in-memory InputStream
to always appear to be at EOF.

Change-Id: I6811d6187a34eaf1fd6c5002550d631decdfc391
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../eclipse/jgit/util/TemporaryBufferTest.java    | 15 +++++++++++++++
 .../org/eclipse/jgit/util/TemporaryBuffer.java    |  5 +++--
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/TemporaryBufferTest.java b/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/TemporaryBufferTest.java
index cc4cad5ee..eb4fb1e87 100644
--- a/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/TemporaryBufferTest.java
+++ b/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/TemporaryBufferTest.java
@@ -52,6 +52,7 @@
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
+import java.io.InputStream;
 import java.util.Arrays;
 
 import org.eclipse.jgit.junit.TestRng;
@@ -248,6 +249,20 @@ public void testLarge_SingleWrite() throws IOException {
 		}
 	}
 
+	@Test
+	public void testInCoreInputStream() throws IOException {
+		final int cnt = 256;
+		final byte[] test = new TestRng(getName()).nextBytes(cnt);
+		final TemporaryBuffer.Heap b = new TemporaryBuffer.Heap(cnt + 4);
+		b.write(test);
+		b.close();
+
+		InputStream in = b.openInputStream();
+		byte[] act = new byte[cnt];
+		IO.readFully(in, act, 0, cnt);
+		assertTrue(Arrays.equals(test, act));
+	}
+
 	@Test
 	public void testInCoreLimit_SwitchOnAppendByte() throws IOException {
 		final TemporaryBuffer b = new TemporaryBuffer.LocalFile();
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/util/TemporaryBuffer.java b/org.eclipse.jgit/src/org/eclipse/jgit/util/TemporaryBuffer.java
index 58ecaa800..8167c776b 100644
--- a/org.eclipse.jgit/src/org/eclipse/jgit/util/TemporaryBuffer.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/util/TemporaryBuffer.java
@@ -548,7 +548,7 @@ public long skip(long cnt) throws IOException {
 			long skipped = 0;
 			while (0 < cnt) {
 				int n = (int) Math.min(block.count - blockPos, cnt);
-				if (n < 0) {
+				if (0 < n) {
 					blockPos += n;
 					skipped += n;
 					cnt -= n;
@@ -567,11 +567,12 @@ public int read(byte[] b, int off, int len) throws IOException {
 			int copied = 0;
 			while (0 < len) {
 				int c = Math.min(block.count - blockPos, len);
-				if (c < 0) {
+				if (0 < c) {
 					System.arraycopy(block.buffer, blockPos, b, off, c);
 					blockPos += c;
 					off += c;
 					len -= c;
+					copied += c;
 				} else if (nextBlock())
 					continue;
 				else