From 873b0b775435275865d93871906e76adccdbf53a Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Sat, 29 Sep 2018 12:45:20 +0900 Subject: [PATCH] FileResolverTest#testNotAGitRepository: Fail when exception is not thrown Error Prone reports: Not calling fail() when expecting an exception masks bugs See https://errorprone.info/bugpattern/MissingFail Change-Id: I9ac844aa6c5a620d9b5d21d2e242347b3788b96a Signed-off-by: David Pursehouse --- .../tst/org/eclipse/jgit/http/test/FileResolverTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/FileResolverTest.java b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/FileResolverTest.java index 82e79b8e5..553c340a7 100644 --- a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/FileResolverTest.java +++ b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/FileResolverTest.java @@ -147,6 +147,7 @@ public void testNotAGitRepository() throws IOException, try { resolver.open(null, name); + fail("opened non-git repository"); } catch (RepositoryNotFoundException e) { assertEquals("repository not found: " + name, e.getMessage());