motiejus
/
jgit
1
Fork 0
Code Releases Activity

Do not close ArchiveOutputStream on error 

If we encounter an I/O error while writing an archive (for example due
to the reader of an HTTP stream closing the connection), the result is
an archive with unclosed entries, causing
TarArchiveOutputStream.finish() to throw IOException("This archives
contains unclosed entries"), hiding the IOException that caused the
early termination.

The unclosed entries are fine: the same exception that occured in the
first place will probably prevent closing the entries before finishing
this partial archive that should be discarded anyway.

It would be nicer to call TarArchiveOutputStream.finish and leave the
underlying OutputStream unclosed --- all callers close it already ---
but that would be a more invasive change so we hold off for now.

Change-Id: I328ced19aa8a1888e5353cdbb6106a85fd72d5d7
Signed-off-by: Jonathan Nieder <jrn@google.com>
This commit is contained in:
Jonathan Nieder 2013-09-23 17:06:18 -07:00
parent 570bba5e7a
commit 8a51c4453d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
org.eclipse.jgit/src/org/eclipse/jgit/api/ArchiveCommand.java
View File

@ -111,7 +111,6 @@ public class ArchiveCommand extends GitCommand<OutputStream> {
* for (...) {
* format.putEntry(out, path, mode, repo.open(objectId));
* }
* } finally {
* out.close();
* }
*
@ -287,8 +286,9 @@ private <T extends Closeable> OutputStream writeArchive(Format<T> fmt) {
walk.getObjectId(idBuf, 0);
fmt.putEntry(outa, name, mode, reader.open(idBuf));
}
} finally {
outa.close();
} finally {
out.close();
}
return out;
} catch (IOException e) {