From 8f9e157cd5093bf8097f0b6defdef530de761e07 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Wed, 19 Oct 2016 12:54:46 +0900 Subject: [PATCH] ArchiveTest: Don't use string concatenation in loop According to FindBugs: In each iteration, the String is converted to a StringBuffer/ StringBuilder, appended to, and converted back to a String. This can lead to a cost quadratic in the number of iterations, as the growing string is recopied in each iteration. Replace string concatenation with StringBuffer. Change-Id: I60e09f274bed6722f4e0e4d096b0f2b1b31ec1b4 Signed-off-by: David Pursehouse --- .../tst/org/eclipse/jgit/pgm/ArchiveTest.java | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/org.eclipse.jgit.pgm.test/tst/org/eclipse/jgit/pgm/ArchiveTest.java b/org.eclipse.jgit.pgm.test/tst/org/eclipse/jgit/pgm/ArchiveTest.java index a503ffdad..35467c630 100644 --- a/org.eclipse.jgit.pgm.test/tst/org/eclipse/jgit/pgm/ArchiveTest.java +++ b/org.eclipse.jgit.pgm.test/tst/org/eclipse/jgit/pgm/ArchiveTest.java @@ -528,15 +528,15 @@ public void testTarPreservesMode() throws Exception { @Test public void testArchiveWithLongFilename() throws Exception { - String filename = ""; + StringBuilder filename = new StringBuilder(); List l = new ArrayList(); for (int i = 0; i < 20; i++) { - filename = filename + "1234567890/"; - l.add(filename); + filename.append("1234567890/"); + l.add(filename.toString()); } - filename = filename + "1234567890"; - l.add(filename); - writeTrashFile(filename, "file with long path"); + filename.append("1234567890"); + l.add(filename.toString()); + writeTrashFile(filename.toString(), "file with long path"); git.add().addFilepattern("1234567890").call(); git.commit().setMessage("file with long name").call(); @@ -548,15 +548,15 @@ public void testArchiveWithLongFilename() throws Exception { @Test public void testTarWithLongFilename() throws Exception { - String filename = ""; + StringBuilder filename = new StringBuilder(); List l = new ArrayList(); for (int i = 0; i < 20; i++) { - filename = filename + "1234567890/"; - l.add(filename); + filename.append("1234567890/"); + l.add(filename.toString()); } - filename = filename + "1234567890"; - l.add(filename); - writeTrashFile(filename, "file with long path"); + filename.append("1234567890"); + l.add(filename.toString()); + writeTrashFile(filename.toString(), "file with long path"); git.add().addFilepattern("1234567890").call(); git.commit().setMessage("file with long name").call();