[errorprone] Fix wrong comparison which always evaluated to false
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/GraphObjectIndex.java:59: error: [ComparisonOutOfRange] ints may have a value in the range -2147483648 to 2147483647; therefore, this comparison to Integer.MAX_VALUE will always evaluate to false if (table[k] > Integer.MAX_VALUE) { ^ See https://errorprone.info/bugpattern/ComparisonOutOfRange We need to check if variable `uint` of type `long` exceeds the maximum possible int value before casting it to `int` below. This was introduced in Ib5c0d6678cb242870a0f5841bd413ad3885e95f6 Change-Id: I675d594f523084be4c1678328cc343065e32d998
This commit is contained in:
parent
cf5ec856bd
commit
916200e278
|
@ -56,7 +56,7 @@ class GraphObjectIndex {
|
||||||
long uint32;
|
long uint32;
|
||||||
for (int k = 0; k < table.length; k++) {
|
for (int k = 0; k < table.length; k++) {
|
||||||
uint32 = NB.decodeUInt32(oidFanout, k * 4);
|
uint32 = NB.decodeUInt32(oidFanout, k * 4);
|
||||||
if (table[k] > Integer.MAX_VALUE) {
|
if (uint32 > Integer.MAX_VALUE) {
|
||||||
throw new CommitGraphFormatException(
|
throw new CommitGraphFormatException(
|
||||||
JGitText.get().commitGraphFileIsTooLargeForJgit);
|
JGitText.get().commitGraphFileIsTooLargeForJgit);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue