From 95ef1e83d0fa7b82adcb93b734a618a570d32240 Mon Sep 17 00:00:00 2001 From: Colby Ranger Date: Wed, 20 Feb 2013 22:59:35 -0800 Subject: [PATCH] Fix off by one error in PackReverseIndex. The last 32bit offset is at Integer.MAX_VALUE. Change-Id: Idee8be3c7887e1d0c8339ff94aceff36dbf000db --- .../src/org/eclipse/jgit/storage/file/PackReverseIndex.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/storage/file/PackReverseIndex.java b/org.eclipse.jgit/src/org/eclipse/jgit/storage/file/PackReverseIndex.java index 990106b93..7eeb02833 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/storage/file/PackReverseIndex.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/storage/file/PackReverseIndex.java @@ -108,7 +108,7 @@ public PackReverseIndex(final PackIndex packIndex) { int i64 = 0; for (final MutableEntry me : index) { final long o = me.getOffset(); - if (o < Integer.MAX_VALUE) + if (o <= Integer.MAX_VALUE) offsets32[i32++] = (int) o; else offsets64[i64++] = o; @@ -120,7 +120,7 @@ public PackReverseIndex(final PackIndex packIndex) { int nth = 0; for (final MutableEntry me : index) { final long o = me.getOffset(); - if (o < Integer.MAX_VALUE) + if (o <= Integer.MAX_VALUE) nth32[Arrays.binarySearch(offsets32, (int) o)] = nth++; else nth64[Arrays.binarySearch(offsets64, o)] = nth++;