motiejus
/
jgit
1
Fork 0
Code Releases Activity

Bazel: Disable SecurityManagerMissingPermissionsTest test 

In Id5376f09f0d a test with dependency on log4j library was added, but
the library was missed to be added to the Bazel build tool chain.

Given that Bazel test runner doesn't suport custom security manager the
test wouldn't pass even if the missing dependency would be added. The
only solution we have for now is to exclude that test from Bazel tool
chain.

Filed a feature request for bazel to support such tests at
https://github.com/bazelbuild/bazel/issues/11146

Bug: 562274
Change-Id: I873a0e09addc583455b68122f66cd3952e485f0e
Signed-off-by: David Ostrovsky <david@ostrovsky.org>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
This commit is contained in:
David Ostrovsky 2020-04-18 00:00:32 +02:00 committed by Matthias Sohn
parent a0aebbd528
commit 9b2f8ced90
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
org.eclipse.jgit.test/BUILD
View File

@ -40,6 +40,7 @@ DATA = [
EXCLUDED = [
PKG + "api/SecurityManagerTest.java",
PKG + "api/SecurityManagerMissingPermissionsTest.java",
]
RESOURCES = glob(["resources/**"])

4
org.eclipse.jgit.test/tests.bzl
View File

@ -42,6 +42,10 @@ def tests(tests):
additional_deps = [
"//lib:jsch",
]
if src.endswith("SecurityManagerMissingPermissionsTest.java"):
additional_deps = [
"//lib:log4j",
]
if src.endswith("JSchSshTest.java"):
additional_deps = [
"//lib:jsch",