From 9e4a455f9bf24f59b7193639a28c8338ae256c87 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Mon, 5 Mar 2018 20:19:25 +0900 Subject: [PATCH] ArchiveCommand: Create archive output stream in try-with-resource Change-Id: I72f4d303945275d400723aa17212b302e051dc15 Signed-off-by: David Pursehouse --- .../src/org/eclipse/jgit/api/ArchiveCommand.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/api/ArchiveCommand.java b/org.eclipse.jgit/src/org/eclipse/jgit/api/ArchiveCommand.java index c29ed0e22..10397f8ac 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/api/ArchiveCommand.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/api/ArchiveCommand.java @@ -392,9 +392,10 @@ public ArchiveCommand(Repository repo) { private OutputStream writeArchive(Format fmt) { try { try (TreeWalk walk = new TreeWalk(repo); - RevWalk rw = new RevWalk(walk.getObjectReader())) { + RevWalk rw = new RevWalk(walk.getObjectReader()); + T outa = fmt.createArchiveOutputStream(out, + formatOptions)) { String pfx = prefix == null ? "" : prefix; //$NON-NLS-1$ - T outa = fmt.createArchiveOutputStream(out, formatOptions); MutableObjectId idBuf = new MutableObjectId(); ObjectReader reader = walk.getObjectReader(); @@ -427,7 +428,6 @@ private OutputStream writeArchive(Format fmt) { walk.getObjectId(idBuf, 0); fmt.putEntry(outa, tree, name, mode, reader.open(idBuf)); } - outa.close(); return out; } finally { out.close();