motiejus
/
jgit
1
Fork 0
Code Releases Activity

[findbugs] Do not ignore exceptional return value of createNewFile() 

Properly handle return value of java.io.File.createNewFile().

Change-Id: I3a74cc84cd126ca1a0eaccc77b2944d783ff0747
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
This commit is contained in:
Matthias Sohn 2011-01-10 22:45:47 +01:00
parent 9ec97688b9
commit a6e3f53069
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/FileResolverTest.java
View File

@ -47,7 +47,6 @@
import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull; import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail; import static org.junit.Assert.fail;
import java.io.File; import java.io.File;
@ -58,6 +57,7 @@
import org.eclipse.jgit.http.server.resolver.ServiceNotEnabledException; import org.eclipse.jgit.http.server.resolver.ServiceNotEnabledException;
import org.eclipse.jgit.junit.LocalDiskRepositoryTestCase; import org.eclipse.jgit.junit.LocalDiskRepositoryTestCase;
import org.eclipse.jgit.lib.Repository; import org.eclipse.jgit.lib.Repository;
import org.eclipse.jgit.util.FileUtils;
import org.junit.Test; import org.junit.Test;
public class FileResolverTest extends LocalDiskRepositoryTestCase { public class FileResolverTest extends LocalDiskRepositoryTestCase {
@ -116,8 +116,7 @@ public void testExportOk() throws IOException {
fail("did not honor export-all flag"); fail("did not honor export-all flag");
} }
export.createNewFile(); FileUtils.createNewFile(export);
assertTrue("has git-daemon-export-ok", export.exists());
resolver = new FileResolver(base, false /* require flag */); resolver = new FileResolver(base, false /* require flag */);
try { try {
resolver.open(null, name).close(); resolver.open(null, name).close();

10
org.eclipse.jgit.test/tst/org/eclipse/jgit/treewalk/filter/IndexDiffFilterTest.java
View File

@ -56,6 +56,7 @@
import org.eclipse.jgit.revwalk.RevCommit; import org.eclipse.jgit.revwalk.RevCommit;
import org.eclipse.jgit.treewalk.FileTreeIterator; import org.eclipse.jgit.treewalk.FileTreeIterator;
import org.eclipse.jgit.treewalk.TreeWalk; import org.eclipse.jgit.treewalk.TreeWalk;
import org.eclipse.jgit.util.FileUtils;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@ -537,8 +538,7 @@ private void deleteFileInFolderAndCommit() throws Exception {
private void createEmptyFolder() throws Exception { private void createEmptyFolder() throws Exception {
File path = new File(db.getWorkTree(), FOLDER); File path = new File(db.getWorkTree(), FOLDER);
path.mkdir(); FileUtils.mkdir(path);
assertTrue(path.isDirectory());
} }
private RevCommit createEmptyFolderAndCommit() throws Exception { private RevCommit createEmptyFolderAndCommit() throws Exception {
@ -548,14 +548,12 @@ private RevCommit createEmptyFolderAndCommit() throws Exception {
private void createEmptyFolderUntracked() throws Exception { private void createEmptyFolderUntracked() throws Exception {
File path = new File(db.getWorkTree(), UNTRACKED_FOLDER); File path = new File(db.getWorkTree(), UNTRACKED_FOLDER);
path.mkdir(); FileUtils.mkdir(path);
assertTrue(path.isDirectory());
} }
private void createEmptyFolderIgnored() throws Exception { private void createEmptyFolderIgnored() throws Exception {
File path = new File(db.getWorkTree(), IGNORED_FOLDER); File path = new File(db.getWorkTree(), IGNORED_FOLDER);
path.mkdir(); FileUtils.mkdir(path);
assertTrue(path.isDirectory());
writeTrashFile(GITIGNORE, GITIGNORE + "\n" + IGNORED_FOLDER + "/"); writeTrashFile(GITIGNORE, GITIGNORE + "\n" + IGNORED_FOLDER + "/");
} }