From a820ff0896efae688352ea6a972aba5092f4e5ce Mon Sep 17 00:00:00 2001 From: Fabio Ponciroli Date: Thu, 3 Mar 2022 17:27:25 +0100 Subject: [PATCH] WinPipeConnector: Resolve warnings by using "equals" instead of "==" Errorprone raises the following warning: "[ReferenceEquality] Comparison using reference equality instead of value equality". Change-Id: Ic73305b2af628f66e7659ea1b839b3a640e3cd8d --- .../transport/sshd/agent/connector/WinPipeConnector.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.jgit.ssh.apache.agent/src/org/eclipse/jgit/internal/transport/sshd/agent/connector/WinPipeConnector.java b/org.eclipse.jgit.ssh.apache.agent/src/org/eclipse/jgit/internal/transport/sshd/agent/connector/WinPipeConnector.java index 7bad90f24..81c653722 100644 --- a/org.eclipse.jgit.ssh.apache.agent/src/org/eclipse/jgit/internal/transport/sshd/agent/connector/WinPipeConnector.java +++ b/org.eclipse.jgit.ssh.apache.agent/src/org/eclipse/jgit/internal/transport/sshd/agent/connector/WinPipeConnector.java @@ -90,7 +90,7 @@ public boolean connect() throws IOException { file = libs.kernel.CreateFile(pipeName, WinNT.GENERIC_READ | WinNT.GENERIC_WRITE, FILE_SHARE_NONE, null, WinNT.OPEN_EXISTING, FILE_ATTRIBUTE_NONE, null); - if (file == null || file == WinBase.INVALID_HANDLE_VALUE) { + if (file == null || WinBase.INVALID_HANDLE_VALUE.equals(file)) { int errorCode = libs.kernel.GetLastError(); if (errorCode == WinError.ERROR_FILE_NOT_FOUND && CANONICAL_PIPE_NAME.equalsIgnoreCase(pipeName)) {