motiejus
/
jgit
1
Fork 0
Code Releases Activity

ReftableTest: Clean up boxing warnings on usage of String.format 

Passing int as an argument to String.format causes a warning:

  The expression of type int is boxed into Integer

Most of these are already suppressed, but there are a couple that are
not. Add suppressions for those.

For the existing ones, move the suppression scope from the method to
the actual usage. Where necessary extract the usage out to a local
variable.

Change-Id: I7a7ff6dec49467e4b5c58d27a231c74e6e1c5437
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
This commit is contained in:
David Pursehouse 2019-12-05 09:54:14 +09:00
parent 62d16a9146
commit b24ec8f715
1 changed files with 26 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/reftable/ReftableTest.java
View File

@ -149,12 +149,13 @@ public void estimateCurrentBytesOneRef() throws IOException {
assertEquals(expBytes, table.length);
}
@SuppressWarnings("boxing")
@Test
public void estimateCurrentBytesWithIndex() throws IOException {
List<Ref> refs = new ArrayList<>();
for (int i = 1; i <= 5670; i++) {
refs.add(ref(String.format("refs/heads/%04d", i), i));
@SuppressWarnings("boxing")
Ref ref = ref(String.format("refs/heads/%04d", i), i);
refs.add(ref);
}
ReftableConfig cfg = new ReftableConfig();
@ -229,7 +230,9 @@ public void hasObjMapRefsNoIndexObjects() throws IOException {
// Fill up 5 blocks.
int N = 256 * 5 / 25;
for (int i= 0; i < N; i++) {
refs.add(ref(String.format("%02d/xxxxxxxxxx", i), i));
@SuppressWarnings("boxing")
Ref ref = ref(String.format("%02d/xxxxxxxxxx", i), i);
refs.add(ref);
}
byte[] table = write(refs, cfg);
@ -425,12 +428,13 @@ public void namespaceHeads() throws IOException {
}
}
@SuppressWarnings("boxing")
@Test
public void indexScan() throws IOException {
List<Ref> refs = new ArrayList<>();
for (int i = 1; i <= 5670; i++) {
refs.add(ref(String.format("refs/heads/%04d", i), i));
@SuppressWarnings("boxing")
Ref ref = ref(String.format("refs/heads/%04d", i), i);
refs.add(ref);
}
byte[] table = write(refs);
@ -439,12 +443,13 @@ public void indexScan() throws IOException {
assertScan(refs, read(table));
}
@SuppressWarnings("boxing")
@Test
public void indexSeek() throws IOException {
List<Ref> refs = new ArrayList<>();
for (int i = 1; i <= 5670; i++) {
refs.add(ref(String.format("refs/heads/%04d", i), i));
@SuppressWarnings("boxing")
Ref ref = ref(String.format("refs/heads/%04d", i), i);
refs.add(ref);
}
byte[] table = write(refs);
@ -453,12 +458,13 @@ public void indexSeek() throws IOException {
assertSeek(refs, read(table));
}
@SuppressWarnings("boxing")
@Test
public void noIndexScan() throws IOException {
List<Ref> refs = new ArrayList<>();
for (int i = 1; i <= 567; i++) {
refs.add(ref(String.format("refs/heads/%03d", i), i));
@SuppressWarnings("boxing")
Ref ref = ref(String.format("refs/heads/%03d", i), i);
refs.add(ref);
}
byte[] table = write(refs);
@ -468,12 +474,13 @@ public void noIndexScan() throws IOException {
assertScan(refs, read(table));
}
@SuppressWarnings("boxing")
@Test
public void noIndexSeek() throws IOException {
List<Ref> refs = new ArrayList<>();
for (int i = 1; i <= 567; i++) {
refs.add(ref(String.format("refs/heads/%03d", i), i));
@SuppressWarnings("boxing")
Ref ref = ref(String.format("refs/heads/%03d", i), i);
refs.add(ref);
}
byte[] table = write(refs);
@ -646,6 +653,7 @@ public void allRefs() throws IOException {
// Fill out the 1st ref block.
List<String> names = new ArrayList<>();
for (int i = 0; i < 4; i++) {
@SuppressWarnings("boxing")
String name = new String(new char[220]).replace("\0", String.format("%c", i + 'a'));
names.add(name);
writer.writeRef(ref(name, i));
@ -785,7 +793,6 @@ public void onlyReflog() throws IOException {
}
}
@SuppressWarnings("boxing")
@Test
public void logScan() throws IOException {
ReftableConfig cfg = new ReftableConfig();
@ -798,6 +805,7 @@ public void logScan() throws IOException {
List<Ref> refs = new ArrayList<>();
for (int i = 1; i <= 5670; i++) {
@SuppressWarnings("boxing")
Ref ref = ref(String.format("refs/heads/%04d", i), i);
refs.add(ref);
writer.writeRef(ref);
@ -830,12 +838,13 @@ public void logScan() throws IOException {
}
}
@SuppressWarnings("boxing")
@Test
public void byObjectIdOneRefNoIndex() throws IOException {
List<Ref> refs = new ArrayList<>();
for (int i = 1; i <= 200; i++) {
refs.add(ref(String.format("refs/heads/%02d", i), i));
@SuppressWarnings("boxing")
Ref ref = ref(String.format("refs/heads/%02d", i), i);
refs.add(ref);
}
refs.add(ref("refs/heads/master", 100));
@ -863,12 +872,13 @@ public void byObjectIdOneRefNoIndex() throws IOException {
}
}
@SuppressWarnings("boxing")
@Test
public void byObjectIdOneRefWithIndex() throws IOException {
List<Ref> refs = new ArrayList<>();
for (int i = 1; i <= 5200; i++) {
refs.add(ref(String.format("refs/heads/%02d", i), i));
@SuppressWarnings("boxing")
Ref ref = ref(String.format("refs/heads/%02d", i), i);
refs.add(ref);
}
refs.add(ref("refs/heads/master", 100));