motiejus
/
jgit
1
Fork 0
Code Releases Activity

[error prone] suppress NonAtomicVolatileUpdate warning in SimpleLruCache 

It's not important to update time field, scalability is more important
than perfect LRU ordering of cache entries.

Change-Id: I22466c580cd3613b81e1989130b2724af9d6c466
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
This commit is contained in:
Matthias Sohn 2019-08-09 01:25:47 +02:00
parent 66cb2d9db4
commit b4cb06b294
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
org.eclipse.jgit/src/org/eclipse/jgit/util/SimpleLruCache.java
View File

@ -159,6 +159,7 @@ public SimpleLruCache(int maxSize, float purgeFactor) {
* *
* @return value mapped for this key, or {@code null} if no value is mapped * @return value mapped for this key, or {@code null} if no value is mapped
*/ */
@SuppressWarnings("NonAtomicVolatileUpdate")
public V get(Object key) { public V get(Object key) {
Entry<K, V> entry = map.get(key); Entry<K, V> entry = map.get(key);
if (entry != null) { if (entry != null) {
@ -185,6 +186,7 @@ public V get(Object key) {
* @throws NullPointerException * @throws NullPointerException
* if the specified key or value is null * if the specified key or value is null
*/ */
@SuppressWarnings("NonAtomicVolatileUpdate")
public V put(@NonNull K key, @NonNull V value) { public V put(@NonNull K key, @NonNull V value) {
map.put(key, new Entry<>(key, value, ++time)); map.put(key, new Entry<>(key, value, ++time));
if (map.size() > maximumSize) { if (map.size() > maximumSize) {