motiejus
/
jgit
1
Fork 0
Code Releases Activity

Unconditionally close repository in unregisterAndCloseRepository 

Repository.close() method is used when reference counting and expiration
needs to be honored. The RepositoryCache.unregisterAndCloseRepository
method should close the repository unconditionally. This is also indicated
from its javadoc.

Change-Id: I19392d1eaa17f27ae44b55eea49dcff05a52f298
This commit is contained in:
Saša Živkov 2016-09-21 11:32:36 +02:00
parent aadbb158e1
commit b7df7d1fd3
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
org.eclipse.jgit/src/org/eclipse/jgit/lib/RepositoryCache.java
View File

@ -305,11 +305,9 @@ private boolean isExpired(Repository db) {
private void unregisterAndCloseRepository(final Key location,
Repository db) {
synchronized (lockFor(location)) {
if (isExpired(db)) {
Repository oldDb = unregisterRepository(location);
if (oldDb != null) {
oldDb.close();
}
Repository oldDb = unregisterRepository(location);
if (oldDb != null) {
oldDb.doClose();
}
}
}