RevWalk: Don't reset ObjectReader when stopping
Applications like UploadPack reset() and reuse the same RevWalk multiple times in very rapid succession. Releasing the ObjectReader's internal state on each use, only to allocate it again on the next cycle kills performance if the ObjectReader has internal caches, or even if the Inflater gets returned and pulled from the InflaterCache too frequently. Making releasing the ObjectReader the application's responsibility when it is done with the RevWalk, which most already do by wrapping their loop in a try/finally block. Change-Id: I3ad188a719e8d7f6bf27d1a7ca16d465534713f4 Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
This commit is contained in:
parent
5664fb3bfb
commit
bc1af8459e
|
@ -129,8 +129,6 @@ RevCommit next() throws MissingObjectException,
|
|||
final RevCommit c = pending.next();
|
||||
if (c == null) {
|
||||
walker.reader.walkAdviceEnd();
|
||||
if (!(walker instanceof ObjectWalk))
|
||||
walker.reader.release();
|
||||
return null;
|
||||
}
|
||||
|
||||
|
@ -179,7 +177,6 @@ else if (canDispose)
|
|||
}
|
||||
} catch (StopWalkException swe) {
|
||||
walker.reader.walkAdviceEnd();
|
||||
walker.reader.release();
|
||||
pending.clear();
|
||||
return null;
|
||||
}
|
||||
|
|
|
@ -1181,7 +1181,6 @@ protected void reset(int retainFlags) {
|
|||
}
|
||||
}
|
||||
|
||||
reader.release();
|
||||
roots.clear();
|
||||
queue = new DateRevQueue();
|
||||
pending = new StartGenerator(this);
|
||||
|
|
Loading…
Reference in New Issue