Merge branch 'stable-5.2' into stable-5.3
* stable-5.2: Fix GC to delete empty fanout directories after repacking Change-Id: I29e1da15396daaf0036bcb92cfb567cc243db5a1 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
This commit is contained in:
commit
c23ccd29b5
|
@ -47,6 +47,7 @@
|
|||
import static org.junit.Assert.assertFalse;
|
||||
import static org.junit.Assert.assertTrue;
|
||||
|
||||
import java.io.File;
|
||||
import java.util.Collections;
|
||||
import java.util.Date;
|
||||
|
||||
|
@ -113,8 +114,24 @@ public void testPackCommitsAndLooseOneWithPruneNow() throws Exception {
|
|||
fsTick();
|
||||
gc.gc();
|
||||
stats = gc.getStatistics();
|
||||
assertNoEmptyFanoutDirectories();
|
||||
assertEquals(0, stats.numberOfLooseObjects);
|
||||
assertEquals(8, stats.numberOfPackedObjects);
|
||||
assertEquals(2, stats.numberOfPackFiles);
|
||||
}
|
||||
|
||||
private void assertNoEmptyFanoutDirectories() {
|
||||
File[] fanout = repo.getObjectsDirectory().listFiles();
|
||||
for (File f : fanout) {
|
||||
if (f.isDirectory()) {
|
||||
String[] entries = f.list();
|
||||
if (entries == null || entries.length == 0) {
|
||||
assertFalse(
|
||||
"Found empty fanout directory "
|
||||
+ f.getAbsolutePath() + " after pruning",
|
||||
f.getName().length() == 2);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
@ -548,9 +548,12 @@ public void prune(Set<ObjectId> objectsToKeep) throws IOException,
|
|||
pm.update(1);
|
||||
if (d.length() != 2)
|
||||
continue;
|
||||
File[] entries = new File(objects, d).listFiles();
|
||||
if (entries == null)
|
||||
File dir = new File(objects, d);
|
||||
File[] entries = dir.listFiles();
|
||||
if (entries == null || entries.length == 0) {
|
||||
FileUtils.delete(dir, FileUtils.IGNORE_ERRORS);
|
||||
continue;
|
||||
}
|
||||
for (File f : entries) {
|
||||
checkCancelled();
|
||||
String fName = f.getName();
|
||||
|
|
Loading…
Reference in New Issue