Merge "Call unlockPack in finally"

This commit is contained in:
David Pursehouse 2018-11-14 22:11:26 -05:00 committed by Gerrit Code Review @ Eclipse.org
commit c56afbf18c
1 changed files with 17 additions and 11 deletions

View File

@ -269,20 +269,26 @@ private void service() throws IOException {
} }
} }
if (unpackError == null) { try {
boolean atomic = isCapabilityEnabled(CAPABILITY_ATOMIC); if (unpackError == null) {
setAtomic(atomic); boolean atomic = isCapabilityEnabled(CAPABILITY_ATOMIC);
setAtomic(atomic);
validateCommands(); validateCommands();
if (atomic && anyRejects()) if (atomic && anyRejects()) {
failPendingCommands(); failPendingCommands();
}
preReceive.onPreReceive(this, filterCommands(Result.NOT_ATTEMPTED)); preReceive.onPreReceive(
if (atomic && anyRejects()) this, filterCommands(Result.NOT_ATTEMPTED));
failPendingCommands(); if (atomic && anyRejects()) {
executeCommands(); failPendingCommands();
}
executeCommands();
}
} finally {
unlockPack();
} }
unlockPack();
if (reportStatus) { if (reportStatus) {
if (echoCommandFailures && msgOut != null) { if (echoCommandFailures && msgOut != null) {