motiejus
/
jgit
1
Fork 0
Code Releases Activity

PackInserterTest: Prevent potential NPE dereferencing Path.getFileName() 

Path.getFileName() may return null if the path has zero elements.

Enclose the dereference in a null-check.

Change-Id: I7ea3d3f07edc13a80b593d28e8fd512a4e1ed56b
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
This commit is contained in:
David Pursehouse 2017-12-08 17:21:35 +09:00
parent 0e5b9f8a39
commit c861c0e2ee
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/PackInserterTest.java
View File

@ -529,9 +529,12 @@ void assertNoBadFiles(File f) throws IOException {
@Override
public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {
String name = file.getFileName().toString();
if (!attrs.isDirectory() && badName.test(name)) {
bad.add(name);
Path fileName = file.getFileName();
if (fileName != null) {
String name = fileName.toString();
if (!attrs.isDirectory() && badName.test(name)) {
bad.add(name);
}
}
return FileVisitResult.CONTINUE;
}