motiejus
/
jgit
1
Fork 0
Code Releases Activity

Remove unused 'shift' variable from PackFile 

This variable was not used for anything, but Eclipse's JDT failed to
notice because of the "shift += " operation within the body of the
while loop.  Here we don't need the shift because we do not decode the
length, but we do have to skip over the bytes that store the length to
locate the delta base.

Bug: 331319
Change-Id: I200a874fd7e39e3adf2640b8cd0f53dcf91ef4c9
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
CC: Remy Suen <remysuen@ca.ibm.com>
This commit is contained in:
Shawn O. Pearce 2010-12-01 09:57:16 -08:00
parent b4359cb829
commit d29b5db695
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
org.eclipse.jgit/src/org/eclipse/jgit/storage/file/PackFile.java
View File

@ -758,12 +758,9 @@ int getObjectType(final WindowCursor curs, long pos) throws IOException {
readFully(pos, ib, 0, 20, curs);
int c = ib[0] & 0xff;
final int type = (c >> 4) & 7;
int shift = 4;
int p = 1;
while ((c & 0x80) != 0) {
while ((c & 0x80) != 0)
c = ib[p++] & 0xff;
shift += 7;
}
switch (type) {
case Constants.OBJ_COMMIT: