ObjectIdSubclassMap: Grow before insertions
If the table needs to be grown, do it before the current insertion rather than after. This is a tiny micro-optimization that allows the compiler to reuse the result of "++size" to compare against previously pre-computed size at which the table should rehash itself. Change-Id: Ief6f81b91c10ed433d67e0182f558ca70d58a2b0 Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
This commit is contained in:
parent
47c2a3a98d
commit
da548dfd2b
|
@ -67,6 +67,8 @@ public class ObjectIdSubclassMap<V extends ObjectId> implements Iterable<V> {
|
|||
|
||||
private int size;
|
||||
|
||||
private int grow;
|
||||
|
||||
private int mask;
|
||||
|
||||
private V[] table;
|
||||
|
@ -127,10 +129,9 @@ public boolean contains(final AnyObjectId toFind) {
|
|||
* type of instance to store.
|
||||
*/
|
||||
public <Q extends V> void add(final Q newValue) {
|
||||
if (table.length - 1 <= size * 2)
|
||||
if (++size == grow)
|
||||
grow();
|
||||
insert(newValue);
|
||||
size++;
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -164,13 +165,12 @@ public <Q extends V> V addIfAbsent(final Q newValue) {
|
|||
i = 0;
|
||||
}
|
||||
|
||||
if (table.length - 1 <= size * 2) {
|
||||
if (++size == grow) {
|
||||
grow();
|
||||
insert(newValue);
|
||||
} else {
|
||||
table[i] = newValue;
|
||||
}
|
||||
size++;
|
||||
return newValue;
|
||||
}
|
||||
|
||||
|
@ -239,6 +239,7 @@ private void grow() {
|
|||
}
|
||||
|
||||
private void initTable(int sz) {
|
||||
grow = sz >> 1;
|
||||
mask = sz - 1;
|
||||
table = createArray(sz);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue