motiejus
/
jgit
1
Fork 0
Code Releases Activity

[infer] Fix resource leak in RepoCommand 

Bug: 509385
Change-Id: I30c427f0dd2fc1fceb6b003dfdee0a05efaefca9
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
This commit is contained in:
Matthias Sohn 2016-12-18 01:54:51 +01:00
parent 1779fb4a57
commit e78626f414
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/RepoCommand.java
View File

@ -180,17 +180,11 @@ public ObjectId sha1(String uri, String ref) throws GitAPIException {
public byte[] readFile(String uri, String ref, String path)
throws GitAPIException, IOException {
File dir = FileUtils.createTempDir("jgit_", ".git", null); //$NON-NLS-1$ //$NON-NLS-2$
Repository repo = Git
.cloneRepository()
.setBare(true)
.setDirectory(dir)
.setURI(uri)
.call()
.getRepository();
try {
try (Git git = Git.cloneRepository().setBare(true).setDirectory(dir)
.setURI(uri).call();
Repository repo = git.getRepository()) {
return readFileFromRepo(repo, ref, path);
} finally {
repo.close();
FileUtils.delete(dir, FileUtils.RECURSIVE);
}
}