motiejus
/
jgit
1
Fork 0
Code Releases Activity

Remove pointless boolean during native push 

The boolean field sentCommand is always true at this point, as it
was assigned just 5 lines above.  So we always set the status of
the update command object to AWAITING_REPORT.

Simplify the logic by dropping the ?: operator.  I assume this is
older code from an attempt to manage dry-run push support within
the native connection, but in fact dry-run support is done higher
up inside of PushProcess.

Change-Id: I450d491bbbb5afecdbf5444ab7169222e856a3bb
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
This commit is contained in:
Shawn O. Pearce 2010-02-09 15:58:37 -08:00
parent 3dd067042f
commit efdcb16be3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java
View File

@ -178,7 +178,7 @@ private void writeCommands(final Collection<RemoteRefUpdate> refUpdates,
}
pckOut.writeString(sb.toString());
rru.setStatus(sentCommand ? Status.AWAITING_REPORT : Status.OK);
rru.setStatus(Status.AWAITING_REPORT);
if (!rru.isDelete())
writePack = true;
}