From f02844caaefcb7450cde2e3ff64485eb87eef6be Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Sat, 29 Sep 2018 12:59:03 +0900 Subject: [PATCH] DirCacheCheckoutTest#testCheckoutHierarchy: Add missing call to fail() Error Prone reports: Not calling fail() when expecting an exception masks bugs See https://errorprone.info/bugpattern/MissingFail Change-Id: I463510342bb6e6b99b31a0fe264d953340784393 Signed-off-by: David Pursehouse --- .../tst/org/eclipse/jgit/lib/DirCacheCheckoutTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/DirCacheCheckoutTest.java b/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/DirCacheCheckoutTest.java index 7cb91a206..534b323fe 100644 --- a/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/DirCacheCheckoutTest.java +++ b/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/DirCacheCheckoutTest.java @@ -929,6 +929,7 @@ public void testCheckoutHierarchy() throws IOException { "e/g3")); try { checkout(); + fail("did not throw CheckoutConflictException"); } catch (CheckoutConflictException e) { assertWorkDir(mkmap("a", "a", "b/c", "b/c", "d", "d", "e/f", "e/f", "e/g", "e/g3"));