From f32d65759c9afdcbec28eb3051ed9138b8e03271 Mon Sep 17 00:00:00 2001 From: Han-Wen Nienhuys Date: Wed, 29 Mar 2017 13:51:57 +0200 Subject: [PATCH] Document the intended use of RepoCommand#setURI() Signed-off-by: Han-Wen Nienhuys Change-Id: I4a59dd8278b7b0026094692127b7f55e89c10bae --- .../src/org/eclipse/jgit/gitrepo/RepoCommand.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/RepoCommand.java b/org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/RepoCommand.java index 31dd51b4f..e105dc063 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/RepoCommand.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/RepoCommand.java @@ -264,7 +264,11 @@ public RepoCommand setInputStream(InputStream inputStream) { } /** - * Set base URI of the pathes inside the XML + * Set base URI of the paths inside the XML. This is typically the name of + * the directory holding the manifest repository, eg. for + * https://android.googlesource.com/platform/manifest, this should be + * /platform (if you would run this on android.googlesource.com) + * or https://android.googlesource.com/platform elsewhere. * * @param uri * @return this command @@ -448,9 +452,10 @@ public RepoCommand setIncludedFileReader(IncludedFileReader reader) { public RevCommit call() throws GitAPIException { try { checkCallable(); - if (uri == null || uri.length() == 0) + if (uri == null || uri.length() == 0) { throw new IllegalArgumentException( - JGitText.get().uriNotConfigured); + JGitText.get().uriNotConfigured); + } if (inputStream == null) { if (manifestPath == null || manifestPath.length() == 0) throw new IllegalArgumentException(