motiejus
/
jgit
1
Fork 0
Code Releases Activity

Do not update the ref hot bit when checking isIndexLoaded 

DfsPackFile.isIndexLoaded() uses the DfsBlockCache.Ref.get() method
to check if the index loaded. However, using the get() method marks
a hot bit in the cache, which can cause the index to never be unloaded
and seem hotter than it really is. Add a has() method which only
checks if the value is not null and does not update the hot bit.

Change-Id: I7e9ed216f6e273e8f5d79ae573973197654419b4
This commit is contained in:
Colby Ranger 2013-11-13 15:19:03 -08:00
parent 371e1a02bd
commit f3b80f1a74
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsBlockCache.java
View File

@ -556,5 +556,9 @@ T get() {
hot = true;
return v;
}
boolean has() {
return value != null;
}
}
}

2
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsPackFile.java
View File

@ -191,7 +191,7 @@ public DfsPackDescription getPackDescription() {
*/
public boolean isIndexLoaded() {
DfsBlockCache.Ref<PackIndex> idxref = index;
return idxref != null && idxref.get() != null;
return idxref != null && idxref.has();
}
/** @return bytes cached in memory for this pack, excluding the index. */