From fabd645fad4bb3a0f17075dcace1e16dafa4be14 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Tue, 6 Mar 2018 16:58:12 +0900 Subject: [PATCH] FS: Open TemporaryBuffer in try-with-resource Change-Id: I52e048e491e838b7f762a5b5f4d148e91049877c Signed-off-by: David Pursehouse --- org.eclipse.jgit/src/org/eclipse/jgit/util/FS.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/util/FS.java b/org.eclipse.jgit/src/org/eclipse/jgit/util/FS.java index b43a7612d..edcb9d7a6 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/util/FS.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/util/FS.java @@ -1227,14 +1227,11 @@ private static boolean shutdownAndAwaitTermination(ExecutorService pool) { */ public ExecutionResult execute(ProcessBuilder pb, InputStream in) throws IOException, InterruptedException { - TemporaryBuffer stdout = new TemporaryBuffer.LocalFile(null); - TemporaryBuffer stderr = new TemporaryBuffer.Heap(1024, 1024 * 1024); - try { + try (TemporaryBuffer stdout = new TemporaryBuffer.LocalFile(null); + TemporaryBuffer stderr = new TemporaryBuffer.Heap(1024, + 1024 * 1024)) { int rc = runProcess(pb, stdout, stderr, in); return new ExecutionResult(stdout, stderr, rc); - } finally { - stdout.close(); - stderr.close(); } }